Skip to content

[13.0] [MIG] agreement sale#398

Merged
OCA-git-bot merged 11 commits intoOCA:13.0from
i-vyshnevska:13-mig-agreement-sale
Mar 10, 2021
Merged

[13.0] [MIG] agreement sale#398
OCA-git-bot merged 11 commits intoOCA:13.0from
i-vyshnevska:13-mig-agreement-sale

Conversation

@i-vyshnevska
Copy link
Copy Markdown
Member

@i-vyshnevska i-vyshnevska commented Oct 16, 2019

migrate agreement sale
related to #397

@max3903
Copy link
Copy Markdown
Member

max3903 commented Oct 16, 2019

@i-vyshnevska Please have a look at #386

@gurneyalex gurneyalex mentioned this pull request Oct 17, 2019
Open
20 tasks
@max3903 max3903 added this to the 13.0 milestone Nov 7, 2019
jgrandguillaume
jgrandguillaume approved these changes Mar 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on functional side

@dreispt
Copy link
Copy Markdown
Member

dreispt commented Apr 6, 2020

There is a code formatting issue preventing a green build:
https://travis-ci.org/github/OCA/contract/jobs/602255402#L295

bealdav and others added 9 commits February 23, 2021 15:31
@bealdav @i-vyshnevska
PORT agreement_sale
e1305ba
@bealdav @i-vyshnevska
FIX agreement_sale: oca remarks
cd72aa9
@max3903 @i-vyshnevska
Update ir.model.access.csv
a07939b
@max3903 @i-vyshnevska
Update __manifest__.py
371aa89
@oca-travis @i-vyshnevska
[UPD] Update agreement_sale.pot
6b393db
@OCA-git-bot @i-vyshnevska
[UPD] README.rst
626d728
@liweijie0812 @i-vyshnevska
Added translation using Weblate (Chinese (Simplified))
3da7683
@liweijie0812 @i-vyshnevska
Translated using Weblate (Chinese (Simplified))
f2e1789 
Currently translated at 100.0% (2 of 2 strings)

Translation: contract-12.0/contract-12.0-agreement_sale
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_sale/zh_CN/
@gurneyalex @i-vyshnevska
[IMP] move some notions from agreement_legal to agreement
4031af0 
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
@i-vyshnevska i-vyshnevska force-pushed the 13-mig-agreement-sale branch 4 times, most recently from c91ea93 to cd8af28 Compare March 1, 2021 08:21
@i-vyshnevska i-vyshnevska force-pushed the 13-mig-agreement-sale branch from cd8af28 to 896f04b Compare March 1, 2021 08:30
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 1, 2021

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Copy Markdown
Member

dreispt commented Mar 10, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 10, 2021

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-398-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 10, 2021
@OCA-git-bot
Merge PR #398 into 13.0
590f98c 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 10, 2021

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-398-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16bd2cf into OCA:13.0 Mar 10, 2021
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 10, 2021

Congratulations, your PR was merged at 3e7706b. Thanks a lot for contributing to OCA. ❤️

olgamarcocb pushed a commit to tegin/contract that referenced this pull request Nov 16, 2021
@OCA-git-bot
Merge PR OCA#398 into 13.0
fe22aa9 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

+1 more reviewer

@TDu TDu TDu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 needs fixing ready to merge

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

10 participants

@i-vyshnevska @max3903 @dreispt @OCA-git-bot @jgrandguillaume @TDu @bealdav @oca-travis @liweijie0812 @gurneyalex